Is this PR only applicable to notification icon? How about all toast messages inside the app, e.g toast SB sent segment, toast RYD time out/error, etc?

If your device shows the red/white YouTube logo in push notifications or in toast messages, then this change does not change that.

This PR changes the system status bar icon (icon with clock/battery/etc), and changes the push notification icon for devices that don't show a large YT icon with push notifications (Google pixel, all other devices that use ASOP launcher behavior).

For devices that show the large app icon (Samsung, probably other manufacturers as well), the only fix is to add a patch option to permanently change the icon (explained in the linked issue). Will do that later in another PR.

If your device shows the red/white YouTube logo in push notifications or in toast messages, then this change does not change that.

Yes, my device shows red YouTube original logo even I applied Custom branding patch and picked revanced branding logo.

Does this ^ icon look correct?

I don’t use notifications in ReVanced, so I can’t check.

In the status bar shade (dropdown panel), the standard YouTube icon is displayed.

The fist nature screenshot is correct, and that video screenshot won't be changed by this PR.

The second screenshot (red/black icon) should be changed by this PR to whatever in-app custom branding is in use. I'm not completely certain, but it looks like your device follows Google ASOP design and the "small icon" is shown in the notification and not the application icon like Samsung and other manufacturers show.

The third screenshot (white YT icon beside the clock) will be changed by this PR for all devices.

It's very strange why they haven't changed. These screenshots were with the latest changes to this PR. Need to recheck.

Do you have a custom icon set in the settings?

For me, new video notifications use the ReVanced status bar icon.

Maybe there's a different code path for some devices, or for different kinds of notifications (like the "background playback enabled" message).

It seems there was some mistake, now it is displayed.

But first of all, the color still needs to be white.

And the icon in the status bar seems to be of normal size, but it is different size from the manager icon.
Maybe this needs to be changed in the manager, but I understand that it won't happen soon, or it won't happen at all.

I think the red icon tint is added by YT, and the extension code can change that.

Should either change the size here to be the same as Manager, or change Manager to be the same size as here. Not sure which size is better.

Current PR:

If compare the status bar icons in my vendor, the correct size is the one that is now.

It roughly corresponds to the height of the original quantum icon.

Need to update revanced_notification_icon_rounded.xml because the modified version I added isn't centered exactly correct.

Otherwise I think this just about ready. Will make another PR to add the permanent icon change patch option.

Make it the same height as the minimum/scaled?

Hmm, I think try using the full vertical space (Or 95% of the vertical space)?

If we use the height of the minimal V then it might look too small.

Some circle icons use the full vertical space (see the 'sleeping' status bar icon in screenshot above).

This is how it is showing to me now (current PR).

We can't make the lines thicker because we're breaking branding rules?
Or maybe can make the circle a solid fill.

I think the V looks too small. The status bar icon is icon is very tiny to begin with.

Maybe we should use the same 'no-ring' status bar icon for all the preset branding types.

Edit: changed all built-in icon styles to use the same status bar icon (icon shown in the first post).

Please confirm if the notification icon tint is now correct.

I don't know how to check the notification icon in music, I don't use comments or subscribes and I've never received notifications here. Let's hope everything works.

The icon seems to have the correct scaling.

I probably add the same one to the PR in manager, it still uses png.

PS: compose manager doesn't show a notification icon in the status bar?
PPS: maybe related to ReVanced/revanced-manager#2710

@MarcaDian Can you check the small icon now? I tried removing the tint and maybe now it'll automatically color it.

Is that blue tint a theme color of your device? If so then that looks correct (and much better than the black/grey color of before).

Is it intentional that a different app name is used in notifications (and during installation)?

Is that blue tint a theme color of your device?

Yes, this is the accent color of the theme.

Notifications use the manifest application name (that name cannot be changed using an in-app setting).

The system YouTube app shows along side patched YouTube in some places such as:

• 'Open with' prompt, that can show when searching in the launcher and picking a shortcut action (Shorts, search, subscriptions).
• The system app list, where both patched YouTube and system YouTube appears (which app is which?)
• The microG registered apps list (is it regular YouTube, or patched YouTube?)

Because the system YouTube app cannot be completely uninstalled, it makes patched YouTube appear identical to the original YouTube for the situations listed above.

To fix this ambiguity, I changed the manifest application name to "YouTube ReVanced" to reduce end user confusion.

The launcher still always shows whatever name the user has selected in the app settings.

I think this is ready. Will merge in a day or two.

By the way, I just noticed in music ReVanced icon is white, unlike YouTube.

What color is YouTube?

The most we can do is tint the small icon (YouTube code tints it red). If the small icon xml itself uses any color except white or black, then the system status bar shows those colors (very surprising that Android would allow that).

Black. Added a screenshot above.

I apologize. I just patched to this pre-release and the icon is black again. I must have installed a version where you inverted the colors.

So it turns out that Android uses colors from xml files.

What color is the small icon if branding is set to original?

If YT shows a white icon, we can change the ReVanced XML to use white (status bar works the same if XML is either black or white)

If original

I can try changing it myself and check, then I'll let you know if it works.

If changing the XML color to white works, then make a PR with the change. Can add a comment to the XML explaining the paths must be white

It seems to work.

Please add these changes directly, I don't have the opportunity to do it right now.

<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright 2024 ReVanced. Not licensed under GPL. See https://github.com/ReVanced/revanced-branding -->
<vector xmlns:android="http://schemas.android.com/apk/res/android"
    android:width="24dp"
    android:height="24dp"
    android:viewportWidth="24"
    android:viewportHeight="24">

    <!-- The path is set to white (#FFFFFF) to ensure the icon appears white in the expanded status bar panel. -->
    <path
        android:fillColor="#FFFFFF"
        android:pathData="M4.03516,3 C3.80859,3,3.59375,3.11719,3.46875,3.30469 C3.34375,3.49609,3.32422,3.73828,3.41406,3.94922 C4.87109,7.27344,9.71875,18.3359,10.707,20.5938 C10.8164,20.8398,11.0586,21,11.3281,21 L12.6719,21 C12.9375,21,13.1836,20.8398,13.293,20.5938 C14.2813,18.3359,19.1289,7.27344,20.5859,3.94922 C20.6758,3.73828,20.6563,3.49609,20.5313,3.30469 C20.4063,3.11719,20.1914,3,19.9648,3 L19.0898,3 C18.8984,3,18.7227,3.11328,18.6445,3.28906 C17.875,5.04688,13.8008,14.3203,12.4414,17.418 C12.3672,17.5938,12.1914,17.707,12,17.707 C11.8086,17.707,11.6328,17.5938,11.5586,17.418 C10.1992,14.3203,6.125,5.04688,5.35547,3.28906 C5.27734,3.11328,5.10156,3,4.91016,3 Z M7.47266,3 C7.26563,3,7.07422,3.10938,6.97266,3.28906 C6.86719,3.46875,6.86719,3.69141,6.97266,3.87109 C8.02344,5.69141,10.4453,9.88672,11.4961,11.7109 C11.6016,11.8906,11.793,12,12,12 C12.207,12,12.3984,11.8906,12.5039,11.7109 C13.5547,9.88672,15.9766,5.69141,17.0273,3.87109 C17.1328,3.69141,17.1328,3.46875,17.0273,3.28906 C16.9258,3.10938,16.7344,3,16.5273,3 Z M7.47266,3" />
</vector>

It's interesting how Android colors a colored PNG notification icon to white/black color.
In the ReVanced manager, the notification icon is a PNG logo with a colored triangle. The same thing happens on YouTube.